[pull] master from beyond-all-reason:master - #219
Merged
Conversation
Three fixes in the in-game keybind editor: a first run that leaves you with almost no keybinds, a save dialog that quietly renumbers the name you typed, and key capture that binds the fake meta key to itself. Profiles now always write a fakemeta line, `none` included, because unbindall leaves the engine's fake meta key alone and a profile that named none was picking up whatever the last one set. AI disclosure: written with assistance from Claude Code.
## Work done The spec replaced VFS.ZlibDecompress with an identity function at file scope and never restored it. Busted runs every spec file in one Lua state and sorts the file list, so spec/luaui/Include/mission_options_spec.lua ran after it with the helper's ZlibCompress paired against the _identity_ ZlibDecompress, and every decode returned nil. Encode through the helper's ZlibCompress and drop the override.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )